Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix likely cause of smarts.__del__ call in ros_driver. #2106

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Fix likely cause of smarts.__del__ call in ros_driver. #2106

merged 2 commits into from
Nov 9, 2023

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented Nov 7, 2023

This should cause SMARTS to be explicitly deleted on the ROS node.

@Gamenot Gamenot linked an issue Nov 7, 2023 that may be closed by this pull request
[Help Request] Problems encountered in SMARTS simulation using ROS #2103
Closed
@Gamenot Gamenot merged commit 7cd8c4c into master Nov 9, 2023
26 checks passed
@Gamenot Gamenot deleted the tucker/bugfix-fix_ros_smarts_cleanup branch November 9, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adaickalavan Adaickalavan Adaickalavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Help Request] Problems encountered in SMARTS simulation using ROS
2 participants
@Gamenot @Adaickalavan