Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix the package test #2056

Merged
merged 6 commits into from
Jun 7, 2023
Merged

Attempt to fix the package test #2056

merged 6 commits into from
Jun 7, 2023

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented Jun 6, 2023

This fixes an error with the test-package-conflicts by using a newer version of the minimal image.

Comment on lines 91 to 94
- name: Install Enchant
run: |
apt-get update --fix-missing
apt-get install -y libenchant-dev
Copy link
Collaborator Author

@Gamenot Gamenot Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be no longer needed with the newer minimal image.

Copy link
Contributor

@saulfield saulfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should add python3.8-dev to the dockerfile as well, to keep them all in one place? Then we can remove it from the test-package-conflicts workflow.

@Gamenot Gamenot merged commit d2cdef2 into master Jun 7, 2023
@Gamenot Gamenot deleted the tucker/patch-ci-1 branch June 7, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants