Extend scenario metadata #2037
Merged
Extend scenario metadata #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
force-pushed
the
tucker/extend_metadata
branch
from
01abb75 to
b12916e
Compare
Gamenot
force-pushed
the
tucker/extend_metadata
branch
from
f1da575 to
e15df7a
Compare
saulfield
reviewed
May 26, 2023
smarts/sstudio/types/scenario.py
Outdated
| @dataclass(frozen=True) | ||
| class ScenarioMetadata: | ||
| """Scenario data that does not have influence on simulation.""" | ||
| """Deprecated. Scenario data that does not have influence on simulation.""" |
There was a problem hiding this comment.
Is there a reason we didn't just change this class? I like the original name better.
There was a problem hiding this comment.
Right, I had changed this already by the time you commented. I forgot to push the updates here. I decided to just use the old name since the way the new class works still acts like the old one.
saulfield
approved these changes
May 26, 2023
|
Something odd is happening with the edit: One of the scenario builds was failing and that resulted |
qianyi-sun
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional information to the metadata. This allows for constrained and unconstrained arguments to be included in the metadata.
I am considering adding additional serialization support.