Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frame stack environment wrapper #2029

Merged
merged 2 commits into from
May 19, 2023
Merged

Remove frame stack environment wrapper #2029

merged 2 commits into from
May 19, 2023

Conversation

Adaickalavan
Copy link
Member

  • Removed FrameStack environment wrapper.
  • If needed, users are (i) more likely to build their own frame stacking functions which fit their needs, or (ii) more likely to use frame stacking functions from RL libraries of their choice.

@Adaickalavan Adaickalavan self-assigned this May 18, 2023
@Gamenot
Copy link
Collaborator

Gamenot commented May 19, 2023

It looks like test_rgb_image is broken by this.

@Adaickalavan
Copy link
Member Author

It looks like test_rgb_image is broken by this.

The smarts/env/wrappers/rgb_image.py and smarts/env/tests/test_rgb_image.py was removed as part of PR #2027 .

@Adaickalavan Adaickalavan merged commit d11cfd1 into master May 19, 2023
@Adaickalavan Adaickalavan deleted the rm-frame-stack branch May 19, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gamenot Gamenot Gamenot approved these changes

@saulfield saulfield Awaiting requested review from saulfield

@qianyi-sun qianyi-sun Awaiting requested review from qianyi-sun

Assignees

@Adaickalavan Adaickalavan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adaickalavan @Gamenot