Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interest color to envision. #2022

Merged
merged 6 commits into from
May 17, 2023
Merged

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented May 16, 2023

@Gamenot Gamenot requested a review from saulfield May 17, 2023 02:55
@Gamenot
Copy link
Collaborator Author

Gamenot commented May 17, 2023

This ended up being abnormally tricky.

  • The first issue is that all the instanced meshes share the same material (which is good for performance reasons) but it meant that changing the diffuseColor would cause all instances to change colour. The solution was recommended to use a colour buffer.
  • However, it seems like gltf files are loaded with some odd scaling that causes colour buffer values to not reflect on the mesh instances the template mesh is still parented to its original root node.

I honestly thought I was going crazy for a bit there because it looked like it should have worked.

envision/web/src/components/vehicles.js Outdated Show resolved Hide resolved
@Gamenot Gamenot merged commit 6921311 into master May 17, 2023
@Gamenot Gamenot deleted the tucker/add-interest-visualization branch May 17, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants