Actor vehicle name same as configuration. #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianyi-sun
approved these changes
Apr 14, 2023
Gamenot
commented
Apr 15, 2023
Comment on lines
+1142
to
+1154
| if self.social_agent_missions is not None: | ||
| groups = [k for k in self.social_agent_missions] | ||
| for group, (actors, _) in self.social_agent_missions.items(): | ||
| for o_group in groups: | ||
| if group == o_group: | ||
| continue | ||
| if intersection := set.intersection( | ||
| set(map(_get_name, actors)), | ||
| map(_get_name, self.social_agent_missions[o_group][0]), | ||
| ): | ||
| raise ValueError( | ||
| f"Social agent mission groups `{group}`|`{o_group}` have overlapping actors {intersection}" | ||
| ) |
There was a problem hiding this comment.
This is to ensure that there are not duplicate actors in the social missions.
saulfield
reviewed
Apr 17, 2023
Adaickalavan
approved these changes
Apr 18, 2023
saulfield
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the vehicle name generated from a social agent actor is the exact same as the name of the social agent actor (the agent id will still be the same as before.)
As a result, actors in social agent missions must be unique.