Skip to content

Fix ReadTheDocs #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Fix ReadTheDocs #1954

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
541c254
Add missing __init__.py file to waymo module
saulfield Apr 11, 2023
64c89fd
Update headers
saulfield Apr 11, 2023
f0d7592
Ignore header for waymo __init__.py file
saulfield Apr 11, 2023
9b9ef14
Fix copyright header
saulfield Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/header_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Collate all files excluding auto generated files of *_pb2.py and *_pb2_grpc.py.
# We also exlude files in the waymo_open_dataset module.
python_files="$(find ./baselines/marl_benchmark ./cli ./envision ./smarts -name '*.py' ! -name '*_pb2.py' ! -name '*_pb2_grpc.py' ! -wholename './smarts/waymo/waymo_open_dataset/__init__.py')"
python_files="$(find ./baselines/marl_benchmark ./cli ./envision ./smarts -name '*.py' ! -name '*_pb2.py' ! -name '*_pb2_grpc.py' ! -wholename './smarts/waymo/waymo_open_dataset/__init__.py' ! -wholename './smarts/waymo/waymo_open_dataset/protos/__init__.py')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious. This path ! -wholename './smarts/waymo/waymo_open_dataset/__init__.py' is being ignored but it has a Huawei copyright header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, looks like it got added at some point. I've changed it to be the Waymo copyright header.

js_files="$(find ./envision/web/src -name '*.js')"
files="$python_files $js_files"

Expand Down
5 changes: 0 additions & 5 deletions smarts/waymo/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,3 @@
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
"""smarts.waymo
===============

Waymo Utility for Browsing Waymo Dataset
"""
14 changes: 14 additions & 0 deletions smarts/waymo/waymo_open_dataset/protos/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Copyright 2021 The Waymo Open Dataset Authors. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# ==============================================================================