Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driving Smarts 2023 environments #1948

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Driving Smarts 2023 environments #1948

merged 7 commits into from
Apr 11, 2023

Conversation

Adaickalavan
Copy link
Member

  • Added new driving-smarts-v2023 benchmark
  • Added new platoon-v0 env
  • Modified naming of benchmark used in NeurIPS 2022 from driving-smarts-competition-env to driving-smarts-v2022

@qianyi-sun
Copy link
Contributor

since we havent officially announced this, would it better if we name the PR and the env name differently until we launch this later?

@Adaickalavan
Copy link
Member Author

since we havent officially announced this, would it better if we name the PR and the env name differently until we launch this later?

This is simply a new set of enviroments which we are adding into SMARTS. It could be used for any purpose. I guess it is better to simply add it in now rather than later. Users are free to explore and start early.

@Adaickalavan Adaickalavan self-assigned this Apr 10, 2023
smarts/benchmark/driving_smarts/v2023/config.yaml Outdated Show resolved Hide resolved
# naturalistic: # reserved for driving_smarts_competition_naturalistic-v0
# loc: "smarts.env:driving_smarts_competition_naturalistic-v0"
# naturalistic:
# loc: "smarts.env:driving-smarts-naturalistic-v2022"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me that we should add a standard way to deal with the naturalistic scenarios.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@Adaickalavan Adaickalavan merged commit 2a2f592 into master Apr 11, 2023
@Adaickalavan Adaickalavan deleted the driving-smarts-2023 branch April 11, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants