Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify scenario paths #1936

Merged
merged 3 commits into from
Apr 2, 2023
Merged

Simplify scenario paths #1936

merged 3 commits into from
Apr 2, 2023

Conversation

Adaickalavan
Copy link
Member

  • Moved benchmark scenarios into SMARTS/scenarios folder.
  • Simplified the scenario loading code in driving_smarts benchmark.

@@ -5,12 +5,12 @@

trajectory_boid_agent = t.BoidAgentActor(
name="trajectory-boid",
agent_locator="scenarios.sumo.straight.agent_prefabs:trajectory-boid-agent-v0",
agent_locator="scenarios.sumo.straight.3lane_bubble.agent_prefabs:trajectory-boid-agent-v0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modules starting with numerals are not Python compliant. This is fine since we support it by loading in dynamically but it is not easy to test this as a regular import.

@Adaickalavan Adaickalavan merged commit 71bbd3c into master Apr 2, 2023
@Adaickalavan Adaickalavan deleted the simplify-benchmark branch April 2, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants