Extract panda3d renderer #1921
Merged
Extract panda3d renderer #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
force-pushed
the
tucker/feature-parallel_observations
branch
from
a085b1a
to
1ea2611
Compare
Gamenot
force-pushed
the
tucker/extract_panda3d_renderer
branch
from
81a1372
to
519f75c
Compare
Gamenot
force-pushed
the
tucker/feature-parallel_observations
branch
from
9882a68
to
d756d63
Compare
Gamenot
force-pushed
the
tucker/extract_panda3d_renderer
branch
from
519f75c
to
1dda96c
Compare
saulfield
approved these changes
Apr 6, 2023
Gamenot
force-pushed
the
tucker/feature-parallel_observations
branch
from
fb9835c
to
0c6b139
Compare
Gamenot
force-pushed
the
tucker/extract_panda3d_renderer
branch
2 times, most recently
from
01f4177
to
c4ecf02
Compare
smarts/core/renderer_base.py
Outdated
| raise NotImplementedError | ||
|
|
||
| @dataclass | ||
| class OffscreenCamera: |
There was a problem hiding this comment.
If possible, consider avoiding nested classes.
There was a problem hiding this comment.
Steve was a fan of this. It does, however, seem unnecessary.
Adaickalavan
approved these changes
Apr 11, 2023
Gamenot
force-pushed
the
tucker/extract_panda3d_renderer
branch
from
c4ecf02
to
1b191da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.