New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix engine configuration bool cast. #1903

Merged

Gamenot merged 1 commit into master from tucker/bugfix_engine_bool_config

Mar 10, 2023

Collaborator

Gamenot commented Mar 10, 2023 •

edited

Loading

Funny behaviour:

int("123") == 123 expected.
bool("false") == True unexpected but understood.
bool("False") == True unfortunate.


          Fix engine configuration

55aaf5d

Gamenot requested review from saulfield, Adaickalavan and qianyi-sun

March 10, 2023 20:18

saulfield approved these changes

View reviewed changes

Adaickalavan approved these changes

View reviewed changes

Gamenot merged commit 95619cd into master

Gamenot deleted the tucker/bugfix_engine_bool_config branch

March 10, 2023 21:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet