Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade bubble tests #1878

Merged
merged 14 commits into from
Mar 3, 2023
Merged

Upgrade bubble tests #1878

merged 14 commits into from
Mar 3, 2023

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented Feb 21, 2023 •
edited
Loading

See CHANGELOG.

TODO:

  • Upgrade bubble tests
  • Bubble handles different cases of vehicle entry without traffic provider
    • Outside -> Airlock -> Bubble -> Airlock -> Outside
    • Outside -> Bubble -> Outside
    • Outside -> Bubble -> Airlock -> Outside
    • Outside -> Airlock -> Outside -> Airlock (bug was found and fixed here)
    • Bubble -> Airlock -> Bubble -> Bubble
    • Split up test cases
  • Bubble handles transfer with traffic provider.
    • Former tests with traffic provider.

Relevant to #1870

@Gamenot Gamenot merged commit 4fa1a67 into master Mar 3, 2023
@Gamenot Gamenot deleted the tucker/upgrade_bubble_tests branch March 3, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adaickalavan Adaickalavan Adaickalavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gamenot @Adaickalavan