Fix agent-mission combination #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 15, 2023
Gamenot
commented
Feb 15, 2023
saulfield
reviewed
Feb 16, 2023
smarts/core/utils/math.py
Outdated
| len(first_group) <= len(second_group) the value is padded. | ||
|
|
||
| padded_product('ab', '123') -> a1 b2 a1 b3 a2 b1 a2 b3 a3 b1 a3 b2 | ||
| padded_product('ab', '1', default="k") -> a1 bk ak b1 |
There was a problem hiding this comment.
This comment might be a bit misleading
- Should it be called
ordered_combinationsinstead ofpadded_product? - From the comment it looks like it returns a linear sequence rather than a sequence of products
There was a problem hiding this comment.
I have clarified the utility and return values.
It should return groups of pairs, where the pairs use only unique indices from the contributor sequences, within each resulting group.
saulfield
approved these changes
Feb 21, 2023
Adaickalavan
approved these changes
Feb 21, 2023
Co-authored-by: Saul Field <[email protected]> Co-authored-by: adai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to ensure that agent and mission combinations are unique and viable across resets.