Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix score computation #1848

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fix score computation #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Copy and pasting the git commit messages is __NOT__ enough.
- Fixed an exit error that occurs when envision attempts to close down.
- Clarified the actions for `ActionSpaceType.Continuous` and `ActionSpaceType.ActuatorDynamic` in their respective docstrings.
- Excluded from wheel any scenario build files in pattern `smarts/**/build/**/*.xml`.
- Fixed an unintended regression in the metrics.
### Removed
- Removed duplicated `smarts.env.gymnasium.action_conversion` module.
### Security
Expand Down
2 changes: 1 addition & 1 deletion smarts/env/gymnasium/wrappers/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ def score(self) -> Score:
humanness = _humanness(costs=costs_tot, agents_tot=agents_tot)
rules = _rules(costs=costs_tot, agents_tot=agents_tot)
time = _time(counts=counts_tot)
overall = completion * (1 - time) * (1 - humanness) * (1 - rules)
overall = completion * (1 - time) * humanness * rules

return Score(
completion=completion,
Expand Down