Fixed bubble rendering issue, added ConfigurableZone #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
requested changes
Nov 4, 2022
saulfield
requested changes
Nov 15, 2022
saulfield
reviewed
Nov 15, 2022
AisenGinn
requested review from
Gamenot and
saulfield
and removed request for
Gamenot
saulfield
approved these changes
Nov 17, 2022
Gamenot
requested changes
Nov 23, 2022
smarts/sstudio/types.py
Outdated
| if not isinstance(self.zone, MapZone): | ||
| poly = self.zone.to_geometry(road_map=None) | ||
| if not poly.is_valid: | ||
| raise ValueError("The Zone Polygon is not a valid closed loop") |
There was a problem hiding this comment.
Is there any context we have that we can used to determine which bubble is having an issue?
Gamenot
approved these changes
Nov 23, 2022
|
Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Envision bubble rendering issue, added ConfigurableZone in to bubble.