Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issues related to files that cannot be loaded #1555

Merged
merged 3 commits into from
Aug 13, 2022
Merged

Fix CI issues related to files that cannot be loaded #1555

merged 3 commits into from
Aug 13, 2022

Conversation

saulfield
Copy link
Contributor

Fixes #1553 and #1554.

@Gamenot
Copy link
Collaborator

Gamenot commented Aug 12, 2022

Curious. How does this fix 1553?

@saulfield
Copy link
Contributor Author

saulfield commented Aug 13, 2022 •
edited
Loading

Curious. How does this fix 1553?

It's the same issue effectively. The notebook test tries to find the scenario path by searching over everything in sys.path. Without the base directory being in there, the scenario path ends up being None (it wasn't the .pkl file that was None as was suspected in the issue).

@saulfield saulfield merged commit ab8ca3c into develop Aug 13, 2022
@saulfield saulfield deleted the saul/test-fix branch August 13, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gamenot Gamenot Gamenot approved these changes

@Adaickalavan Adaickalavan Adaickalavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saulfield @Gamenot @Adaickalavan