Video recording utilities #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
requested changes
Jul 14, 2022
Gamenot
approved these changes
Jul 27, 2022
|
@AisenGinn Please bug people to review this so it does not sit too long. |
saulfield
requested changes
Nov 15, 2022
…tation to clarify each path.
AisenGinn
requested review from
Gamenot and
saulfield
and removed request for
saulfield,
qianyi-sun and
Gamenot
Gamenot
requested changes
Nov 17, 2022
smarts/env/wrappers/gif_recorder.py
Outdated
Comment on lines
29
to
33
| try: | ||
| from moviepy.editor import ImageClip, ImageSequenceClip | ||
| except (ImportError, ModuleNotFoundError): | ||
| print(sys.exc_info()) | ||
| print( | ||
| "You may not have installed the [gym] dependencies required to capture the video. Install them first using the command `pip install -e .[gym]` at the source directory." | ||
| ) |
There was a problem hiding this comment.
I think my last concern here is that this try/catch swallows the import error. I think we still want to raise an error here. Aside from that we should not expect that the user is working from a dev platform.
Suggested change
| try: | |
| from moviepy.editor import ImageClip, ImageSequenceClip | |
| except (ImportError, ModuleNotFoundError): | |
| print(sys.exc_info()) | |
| print( | |
| "You may not have installed the [gym] dependencies required to capture the video. Install them first using the command `pip install -e .[gym]` at the source directory." | |
| ) | |
| try: | |
| from moviepy.editor import ImageClip, ImageSequenceClip | |
| except (ImportError, ModuleNotFoundError): | |
| logging.warning(sys.exc_info()) | |
| logging.warning( | |
| "You may not have installed the [gym] dependencies required to capture the video. Install them first with the `smarts[gym]` extras." | |
| ) | |
| raise |
…develop update branch to follow the newest develop.
saulfield
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gif_recorder.py and recorder_wrapper.py into smarts.env.wrappers folder for video recording function.