Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single vehicle in traffic #1466

Merged
merged 14 commits into from
Nov 17, 2022
Merged

Single vehicle in traffic #1466

merged 14 commits into from
Nov 17, 2022

Conversation

AisenGinn
Copy link
Contributor

@AisenGinn AisenGinn commented Jun 14, 2022

Added trip consisted of single vehicle and route in sstudio.type.py. Added code for writing xml of trip in generator.py.

smarts/sstudio/types.py Outdated Show resolved Hide resolved
smarts/sstudio/generators.py Outdated Show resolved Hide resolved
smarts/sstudio/types.py Outdated Show resolved Hide resolved
smarts/sstudio/types.py Outdated Show resolved Hide resolved
smarts/sstudio/types.py Outdated Show resolved Hide resolved
scenarios/straight/scenario.py Outdated Show resolved Hide resolved
smarts/sstudio/generators.py Outdated Show resolved Hide resolved
smarts/sstudio/types.py Outdated Show resolved Hide resolved
smarts/sstudio/generators.py Outdated Show resolved Hide resolved
smarts/sstudio/generators.py Outdated Show resolved Hide resolved
@AisenGinn AisenGinn changed the title Iss1435 Single vehicle in traffic Jul 27, 2022
@AisenGinn AisenGinn closed this Jul 27, 2022
@AisenGinn AisenGinn reopened this Jul 27, 2022
@AisenGinn AisenGinn closed this Jul 27, 2022
@AisenGinn AisenGinn reopened this Jul 27, 2022
@AisenGinn AisenGinn requested a review from Gamenot July 28, 2022 15:17
Copy link
Contributor

@saulfield saulfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, otherwise looks good to merge.

smarts/sstudio/generators.py Outdated Show resolved Hide resolved
…ion for trip. Added Vtype in writexml for trip.
@AisenGinn AisenGinn requested review from saulfield and removed request for Gamenot November 16, 2022 19:26
Copy link
Collaborator

@Gamenot Gamenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final changes, after this is addressed we can merge it.

smarts/sstudio/generators.py Outdated Show resolved Hide resolved
smarts/sstudio/types.py Outdated Show resolved Hide resolved
smarts/sstudio/generators.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Gamenot
Copy link
Collaborator

Gamenot commented Nov 17, 2022

Good work.

@Gamenot Gamenot merged commit 748171a into huawei-noah:develop Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants