Fix score computation. (#1848)

huawei-noah · Feb 9, 2023 · 254e942 · 254e942
1 parent 7ff08fc
commit 254e942
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ Copy and pasting the git commit messages is __NOT__ enough.
 - Fixed an exit error that occurs when envision attempts to close down.
 - Clarified the actions for `ActionSpaceType.Continuous` and `ActionSpaceType.ActuatorDynamic` in their respective docstrings.
 - Excluded from wheel any scenario build files in pattern `smarts/**/build/**/*.xml`.
+- Fixed an unintended regression in the metrics.
 ### Removed
 - Removed duplicated `smarts.env.gymnasium.action_conversion` module.
 ### Security

diff --git a/smarts/env/gymnasium/wrappers/metrics.py b/smarts/env/gymnasium/wrappers/metrics.py
@@ -291,7 +291,7 @@ def score(self) -> Score:
         humanness = _humanness(costs=costs_tot, agents_tot=agents_tot)
         rules = _rules(costs=costs_tot, agents_tot=agents_tot)
         time = _time(counts=counts_tot)
-        overall = completion * (1 - time) * (1 - humanness) * (1 - rules)
+        overall = completion * (1 - time) * humanness * rules
 
         return Score(
             completion=completion,