Add ability to define custom data types #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Currently, the library supports only a limited number of types -
array, hash, big_decimal, integer, float, string, boolean
.I have a need to save custom types into a DB, so I decided to try to add the functionality that will allow me to do that. During implementation, I also tried to refactor a little bit of other code in order to make it more readable.
So here is what I've done so far:
Take note, that I was trying to keep us much backward compatibility as I can. At this moment it seems like all tests are being passed successfully.
Maintainers (@codez @berkos @huacnlee), could you please let me know whether it makes sense?
If yes, I will prepare the PR for the merge. If not - you are free to close it :)