Skip to content

use stack ncdiag, update hera.gnu hpc-stack, update to head of develop#12

Merged
hu5970 merged 5 commits into
hu5970:intel2022from
RussTreadon-NOAA:intel2022
Jul 10, 2023
Merged

use stack ncdiag, update hera.gnu hpc-stack, update to head of develop#12
hu5970 merged 5 commits into
hu5970:intel2022from
RussTreadon-NOAA:intel2022

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Collaborator

@RussTreadon-NOAA RussTreadon-NOAA commented Jul 2, 2023 •
edited
Loading

Description
This PR updates

  • gsi_common.lua to use machine specific stack ncdiag/1.1.1
  • gsi_hera.gnu.lua to use epic hpc-stack
  • files enkf/gridio_fv3reg.f90, enkf/gridio_gfs.f90, src/enkf/innovstats.f90 to current head (333ae16) of NOAA-EMC/GSI develop

NOTE: The change to gsi_common.lua results in the WCOSS2 build failing because ncdiag/1.1.1 has not yet been installed in the official WCOSS2 stack.

Addresses open items in PR #571.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?
intel2022 has been cloned and built on Orion and Hera. Both intel and gnu builds were executed on Hera. All builds successfully completed.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

TingLei-daprediction and others added 4 commits June 27, 2023 00:15
@TingLei-daprediction
Feature/enkf q2 (#568)
00cac54 
Resubmit PR for cleaning the unneeded item in the previous PR 
In correspondence to the EMC GSI Issue#566, this PR contains a quick
adding of the clipping of negative values of sphum (q) in the analysis
of FV3-LAM EnKF.
This part of codes are not tested in the current GSI regression tests,
which, hence, are not run.
The current codes are verified using local FV3-LAM case. It is found the
differences from this changes exist for sphum ( maximum values about
0.003 (units) and 0.3 K for T (sensible T). The latter is because the
sphum would be used when the analysis TV is converted to T. All
differences are on spontaneous points and values are reasonable as
expected.
Hence, the code is regarded as verified.

Fixes #566

**DUE DATE for this PR is 6/15/2023.** If this PR is not merged into
`develop` by this date, the PR will be closed and returned to the
developer.
@emilyhcliu
Zero increments for precipitation hydrometeors are written as missing…
333ae16 
… values instead of zeros (#578)
@RussTreadon-NOAA
update hera.gnu modulefile to use epic hpc-stack, load ncdiag from ma…
44feb8a 
…chine stacks
@RussTreadon-NOAA
Merge branch 'NOAA-EMC:develop' into intel2022
ffba673
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Jul 2, 2023
Merged
@DavidHuber-NOAA
Copy link
Copy Markdown

DavidHuber-NOAA commented Jul 3, 2023

@RussTreadon-NOAA It looks like the w3nco load snuck it's way back into the gsi_common.lua modulefile. This should be removed.

@RussTreadon-NOAA
Copy link
Copy Markdown
Collaborator Author

RussTreadon-NOAA commented Jul 3, 2023

load(pathJoin("w3nco", w3nco_ver)) is in hu5970:intel2022. It entered gsi_common.lua at 1359145.

I will remove the w3nco entry from gsi_common.lua in RussTreadon-NOAA:intel2022 ... though doing so is outside the intended scope of this PR.

@RussTreadon-NOAA
Copy link
Copy Markdown
Collaborator Author

RussTreadon-NOAA commented Jul 3, 2023

@DavidHuber-NOAA and @natalie-perlin, modulefiles/gsi_cheyenne.gnu.lua references w3nco with the following comment

-- Preload w3nco to work around nemsio "find_dependency(w3nco)" hpc-stack bug
load("w3nco/2.4.1")

Has the hpc-stack bug on Cheyenne been resolved? If so, I will remove this w3nco reference, too.

@DavidHuber-NOAA
Copy link
Copy Markdown

DavidHuber-NOAA commented Jul 3, 2023

@RussTreadon-NOAA @natalie-perlin I verified that this is not an issue for nemsio/2.5.4 on Cheyenne when loading through hpc-gnu/10.1.0 hpc-mpt/2.25. I think this is only an issue for nemsio/2.5.2, which uses w3nco, while 2.5.4 does not. If the plan is to use mpt/2.22, then I cannot say for certain as it does not exist yet, but I'm strongly inclined to say it would be fine to remove it.

@natalie-perlin
Copy link
Copy Markdown

natalie-perlin commented Jul 3, 2023 •
edited
Loading

@RussTreadon-NOAA @DavidHuber-NOAA -
Yes, the dependency is indeed only for nemsio/2.5.2.
Also, use of mpt/2.22 was retired for use with hpc-stack. We have several gnu-based hpc-stacks in EPIC locations, all with mpt/2.25. Neither UFS-WM, nor UFS-SRW use the older 2.22 version since last year.

@RussTreadon-NOAA
Copy link
Copy Markdown
Collaborator Author

RussTreadon-NOAA commented Jul 10, 2023

@hu5970 , if you are OK with these changes, would you please approve and merge. I can not approve my own PR.

These changes in this PR are twofold:

  • update modulefiles: use ncdiag/1.1.1 and use epic-stack for gsi_hera.gnu.lua
  • update hu5970:intel2022 to the head of develop

@DavidHuber-NOAA
Copy link
Copy Markdown

DavidHuber-NOAA commented Jul 10, 2023

@RussTreadon-NOAA Can we also remove the w3nco load from gsi_common.lua? This dependency was removed with nemsio/2.5.4. @natalie-perlin confirmed that it is not needed for Cheyenne, either.

@RussTreadon-NOAA
Copy link
Copy Markdown
Collaborator Author

RussTreadon-NOAA commented Jul 10, 2023

@DavidHuber-NOAA , w3nco removed at 3d47231. Please confirm that this is satisfactory.

@DavidHuber-NOAA
Copy link
Copy Markdown

DavidHuber-NOAA commented Jul 10, 2023

@RussTreadon-NOAA Yes, thank you, this is what was desired.

@hu5970 hu5970 merged commit 06ad860 into hu5970:intel2022 Jul 10, 2023
@RussTreadon-NOAA RussTreadon-NOAA deleted the intel2022 branch July 10, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hu5970 hu5970 hu5970 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RussTreadon-NOAA @DavidHuber-NOAA @natalie-perlin @hu5970 @TingLei-daprediction @emilyhcliu