Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial changes to Safe Method With Body #2859

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hawkinsw
Copy link

@hawkinsw hawkinsw commented Aug 7, 2024

A minor typographical fix and slight rephrasing of limitations of current query-embedded-in-request-URI method.

@hawkinsw
Copy link
Author

hawkinsw commented Aug 7, 2024

I hope that I have followed the proper procedures for proposing (and labeling) an editorial suggestion. I hope that this is helpful!

@reschke
Copy link
Contributor

reschke commented Sep 7, 2024

Yes, that's the right procedure!

I think the change goes into the right direction.

Two issues though:

  • you lost some of the original text, can you add that?
  • XML: <ul> is a block-level element and needs to be pulled outside the <t>.

A minor typographical fix and slight rephrasing of limitations of current query-embedded-in-request-URI method.
@hawkinsw
Copy link
Author

hawkinsw commented Sep 9, 2024

Yes, that's the right procedure!

I think the change goes into the right direction.

Two issues though:

* you lost some of the original text, can you add that?

My goal was to reflow the content into those three bullets. Did I accidentally delete other content while doing that? If so, I am very sorry!

* XML: <ul> is a block-level element and needs to be pulled outside the <t>.

I believe that I fixed this issue! Sorry!

I made sure that everything compiled with this version (as opposed to the first version -- sorry!)

I hope that this helps!
Will

Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions, but small ones.

draft-ietf-httpbis-safe-method-w-body.xml Outdated Show resolved Hide resolved
draft-ietf-httpbis-safe-method-w-body.xml Outdated Show resolved Hide resolved
hawkinsw and others added 2 commits September 9, 2024 22:16
Accept @martinthomson helpful feedback!

Co-authored-by: Martin Thomson <[email protected]>
Accepting additional feedback - thanks.

Co-authored-by: Martin Thomson <[email protected]>
@hawkinsw
Copy link
Author

Thank you @martinthomson ! I incorporated all those helpful suggestions!

@reschke
Copy link
Contributor

reschke commented Sep 11, 2024

Will,

  1. could you restore "Often these limits are not known or discoverable ahead of...."?
  2. I'm not sure we want to reference NO-VARY-SEARCH; maybe you can open a separate ticket/PR, so we can discuss this separately?

@hawkinsw
Copy link
Author

Will,

1. could you restore "Often these limits are not known or discoverable ahead of...."?

2. I'm not sure we want to reference NO-VARY-SEARCH; maybe you can open a separate ticket/PR, so we can discuss this separately?

Absolutely! I was just trying to respond to @martinthomson !! I will send another version in the next few hours! Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants