-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify the compression window sizes for zstd-d and br-d #2769
Conversation
@nidhijaju could you PTAL and make sure the language matches what you're working on for the |
…gistry to this document
Thanks. I switched the content-encodings definitions and IANA registrations to a list with references back to the algorithm RFCs. For the IANA registrations I removed the window size from the text and linked it to this document (where the window sizes are defined) instead of to the compression algorithms directly. Let me know if a more verbose description of the need to specify the window sizes would be useful or if just being explicit about what they are is enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than the comment
This change makes it explicit that the
zstd-d
content encoding isZstandard with up to a 8 MB compression window
(same aszstd
) andbr-d
isBrotli with up to a 16 MB compression window
(same asbr
).See the discussion in #2754 for why larger ZStandard values were not selected.
This carries some nuance for what encoding to use when compressing for maximum benefit as the resource size crosses beyond 8 MB but that is more of an editorial discussion about the individual compression algorithms and probably better laid out in blog posts or explainers than in the spec.
Fix #2754