-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HMAC and switch to Authorization #2571
Conversation
|
||
# Authentication Parameters | ||
|
||
This specification defines the following authentication parameters, they can be | ||
used by the authentication schemes defined in {{schemes}}. | ||
This specification defines the following authentication parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are using structured fields for the definitions of these, even though Authorization doesn't use SF. That's good, but I might take this opportunity to make this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I agree with the idea but I'm not sure I see what you mean. Do you have thoughts on how best to make said point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"These parameters use SF [RFC8941 (or -bis)] in their definition, though the Authorization field does not use SF."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Christopher Wood <[email protected]>
Fixes #2440
Fixes #2432