Adds Content-Type to Data HttpResponse #450
Conversation
|
@SoftwareEngineerChris Thanks for taking the time to create this PR. Please rebase from the latest changes related to the CI to be able to review this. |
SoftwareEngineerChris
force-pushed
the
data-with-content-type
branch
from
bf2effd to
c0e19e6
Compare
|
Sorry for the delay @Vkt0r. The actions have run, but it looks like the Danger job failed because it doesn't have an API key set. |
|
Uhmm interesting 🤔, the project is exposing the secret successfully. Found these keys in your ENV: GITHUB_JOB, GITHUB_EVENT_PATH, **DANGER_GITHUB_API_TOKEN**, ...But this looks like an issue with Danger danger/danger#685. I'll take a look at Danger soon to try to reproduce this issue running it locally. Thanks for reporting this 👍. |
|
Cheers @Vkt0r - is there anything I can do? |
|
@SoftwareEngineerChris Sorry for the delay! In the meantime we figure out the issue with Danger can please add your change to the |
No problem! For sure, will do. |
SoftwareEngineerChris
force-pushed
the
data-with-content-type
branch
from
c0e19e6 to
39351c1
Compare
|
Oh that rebase didn't go well. Let me do that again. |
SoftwareEngineerChris
force-pushed
the
data-with-content-type
branch
from
39351c1 to
ea4168f
Compare
Adds Data HttpResponse 'Content-Type' addition to CHANGLOG.md
SoftwareEngineerChris
force-pushed
the
data-with-content-type
branch
from
ea4168f to
9c9105d
Compare
|
All sorted @Vkt0r - thanks. |
…-content-type Adds Content-Type to Data HttpResponse
This PR allows the
Content-TypeHTTP header to be set when using the dataHttpResponse.