Move WebSocketHandshake to blaze-core #6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
series/0.23
rossabaker
force-pushed
the
web-socket-handshake
branch
from
1c4c493 to
5d6703a
Compare
danicheg
approved these changes
Mar 25, 2022
|
Yes, it should be. I don't think anybody is using it other than blaze. I only left it because it was scoped broadly enough it might have been used in another repo that I wasn't thinking of. |
rossabaker
added a commit
to http4s/blaze
that referenced
this pull request
May 26, 2022
…shake Move WebSocketHandshake to blaze-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while looking for hidden
Randoms while that's a hot topic in Cats-Effect. After I toiled to make it compile, it turns out the client handshake still isn't used, but it does provide a round-trip test to ensure the server side works.The original version can go poof on merge to main.