Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate client.Connection and client.ConnectionBuilder #5871

Merged
merged 3 commits into from
Jan 15, 2022

Conversation

rossabaker
Copy link
Member

These are blaze-specific types and clutter the Client namespace.

We keep the traits in the blaze package, because some tests use non-BlazeConnection implementations.

All the affected types are private, so generous MiMa exceptions are granted. I'd rather not, but I think the alternative is an avalanche of @nowarn.

@rossabaker rossabaker added breaking Change breaks compatibility (binary or source) module:client labels Jan 14, 2022
@mergify mergify bot added the series/0.22 PRs targeting 0.22.x label Jan 14, 2022
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rossabaker rossabaker merged commit 326aa12 into series/0.22 Jan 15, 2022
@rossabaker rossabaker deleted the deprecate-connection branch January 22, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Change breaks compatibility (binary or source) module:client series/0.22 PRs targeting 0.22.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants