Hello, http4s-blaze #628
Merged
Hello, http4s-blaze #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update scalafmt
Non-trivial merge into 0.23
…affold-0.23 http4s/http4s# Conflicts: http4s/http4s# blaze-client/src/test/scala/org/http4s/blaze/client/BlazeClientBase.scala http4s/http4s# build.sbt http4s/http4s# client/jvm/src/test/scala/org/http4s/client/ServerScaffold.scala
http4s/http4s# Conflicts: http4s/http4s# client/src/test/scala/org/http4s/client/JettyScaffold.scala
…links Fix dead links to RFC
Tweak unused args suppressing
…2-0.23-20220429 Merge 0.22 -> 0.23
…#3707 Drain response body in `DefaultClienthttp4s/http4s#defaultOnError`
…wirl Bye-bye twirl
…ropwizard-prometheus Bye-bye dropwizard, prometheus
…timeout Use `GenTemporal` for proceeding with timeouts
Publish `http4s-client-testkit` module
armanbilge
commented
May 20, 2022
| @@ -3,20 +3,40 @@ import Dependencies._ | |||
|
|
|||
| val Scala212 = "2.12.15" | |||
| val Scala213 = "2.13.8" | |||
| val Scala3 = "3.0.2" | |||
| val Scala3 = "3.1.2" | |||
| val http4sVersion = "0.23.11-473-e7e64cb-SNAPSHOT" | |||
There was a problem hiding this comment.
Blaze currently depends on some unpublished changes in http4s.
| "2.13" -> "0.14.5", | ||
| "3" -> "0.15.0" | ||
| ) | ||
| ThisBuild / tlBaseVersion := "0.23" |
There was a problem hiding this comment.
This will bump the version for blaze's own modules, from 0.15.
| url("https://github.com/ChristopherDavenport")) | ||
| ), | ||
| startYear := Some(2014) | ||
| scalafmtConfig := file(".scalafmt.blaze.conf") |
There was a problem hiding this comment.
I didn't have the heart to re-format the old or the new, so there are two separate configs now. I leave it to the maintainers to reconcile. I did sacrifice the examples, but anyway.
There was a problem hiding this comment.
I'd rather reformat the old, because it moves slower than the new, but that can be done in a separate PR.
|
I think there's more to do here eventually. For instance, two cores is weird. But this gets things started. |
rossabaker
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get things operational, but I think interesting decisions lie ahead for this project.