Add package private isAlive and specific Exception type #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for this is to make it possible to not submit a new task when the TickWheelExecutor is being shutdown. This mostly happens at the end, so we just want to make sure we dont submit or fail with an exception.
aeons
approved these changes
May 25, 2021
rossabaker
approved these changes
May 25, 2021
|
oh, this was based on series/0.14, so I must have missed when opening the PR |
|
Changed the base to series/0.14, probably needs a rebuild to make sure. |
hamnis
commented
May 25, 2021
core/src/main/scala/org/http4s/blaze/util/TickWheelExecutor.scala
Outdated
Show resolved
Hide resolved
rossabaker
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is to make it possible to not submit a new task when the TickWheelExecutor is being shutdown.
This mostly happens at the end, so we just want to make sure we dont submit or fail with an exception.