Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents acceptable endpoint fns #177

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Documents acceptable endpoint fns #177

merged 2 commits into from
Apr 17, 2019

Conversation

fairingrey
Copy link
Contributor

Description

Adds an example of a Tide endpoint that does not make use of async

Motivation and Context

Resolves #19

How Has This Been Tested?

The docs should build correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@yoshuawuyts yoshuawuyts merged commit 9e0a19a into http-rs:master Apr 17, 2019
@fairingrey fairingrey deleted the document-endpoints branch April 17, 2019 21:34
yoshuawuyts pushed a commit that referenced this pull request Apr 18, 2019
* fix: sync up with nightly futures_api

* update dep versions

Now that http-rs/http-service#14 has landed, update dep versions. (Though this also requires http-rs/http-service#17 now)

* Update .travis.yml

* Documents acceptable endpoint fns (#177)

* expand on endpoint Fn's

* use ready! macro instead

* compiler pragmas

Add some good practise pragmas.

Additionally, this also worksaround clippy bug allowing it to pass with the addition of crate level `#![allow(clippy::needless_lifetimes)]`. It's applied on a crate level so as to avoid this from being added repeatedly across the modules or functions - and since it's strictly a  temporary measure. 

Related: #176

* fix: 2018 edition lints

* fix: cargo fmt check in the last commit

* fix: sync up with nightly futures_api

* update dep versions

Now that http-rs/http-service#14 has landed, update dep versions. (Though this also requires http-rs/http-service#17 now)

* Update .travis.yml

* fix: docs using old futures macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document endpoint signatures
2 participants