Skip to content

Issue #896: provide a "proxyReq" event also for websocket connections. - #897

Merged
jcrugzz merged 2 commits into
http-party:masterfrom
lbrucher:issue-896
Oct 22, 2015
Merged

Issue #896: provide a "proxyReq" event also for websocket connections.#897
jcrugzz merged 2 commits into
http-party:masterfrom
lbrucher:issue-896

Conversation

@lbrucher

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread test/lib-http-proxy-test.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight nitpick on naming, res should be socket

@jcrugzz

jcrugzz commented Oct 22, 2015

Copy link
Copy Markdown
Contributor

@lbrucher Looks good, will get it in a release later today 👍

@lbrucher

Copy link
Copy Markdown
Contributor Author

fixed, thanks for the checks!

jcrugzz added a commit that referenced this pull request Oct 22, 2015
Issue #896: provide a "proxyReq" event also for websocket connections.
@jcrugzz
jcrugzz merged commit 0bc4c78 into http-party:master Oct 22, 2015
@andrewpmartinez

Copy link
Copy Markdown

=\

I suppose: #883 can be closed along with #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants