Update options.changeOrigin description in docs#1130
Open
asvae wants to merge 1 commit intohttp-party:masterfrom
Open
Update options.changeOrigin description in docs#1130asvae wants to merge 1 commit intohttp-party:masterfrom
asvae wants to merge 1 commit intohttp-party:masterfrom
Conversation
changeOrigin has nothing to do with `origin` header which is confusing and harmful when working with CORS. As CORS middleware sometimes makes decisions depending on `origin` header. `changeOrigin` option handles solely `host` header.
|
Correct, but in my opinion, the |
|
While discussion on removing changeOrigin continues, can we not update the docs to clarify what the setting actually does? It does not change the origin header but consuming projects assume it does. |
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changeOrigin has nothing to do with
originheader which is confusing and harmful when working with CORS. As CORS middleware sometimes makes decisions depending onoriginheader.changeOriginoption handles solelyhostheader.