Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash when file path errors #753

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Don't crash when file path errors #753

merged 1 commit into from
Oct 18, 2021
+135 −98

Conversation

thornjad
Copy link
Member

@thornjad thornjad commented Oct 18, 2021 •
edited
Loading

When an invalid file path, such as one that contains a null byte (0x00), report this as an error without crashing.

Relevant issues

Fixes #502

Contributor checklist
  • Provide tests for the changes (unless documentation-only)
  • Documented any new features, CLI switches, etc. (if applicable)
    • Server --help output
    • README.md
    • doc/http-server.1 (use the same format as other entries)
  • The pull request is being made against the master branch
Maintainer checklist
  • Assign a version triage tag
  • Approve tests if applicable

@thornjad thornjad added patch version Small, non-breaking, bug fix or trivial change fix labels Oct 18, 2021
@thornjad thornjad merged commit 1e89681 into master Oct 18, 2021
@thornjad thornjad deleted the null-byte-crash branch October 18, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix patch version Small, non-breaking, bug fix or trivial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NULL byte in request path kills server
1 participant
@thornjad