Fix security vulnerability GHSA-vh95-rmgr-6w4m. #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2020
Contributor
Author
|
Looks like Travis had an error reporting the build status to GitHub — the build has completed successfully on Travis. @thornjad for your review when, well, other priorities permit. Hope you’re healthy and holding up okay! ❤️ |
This comment has been minimized.
This comment has been minimized.
thornjad
approved these changes
Apr 27, 2020
thornjad
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Fixes GHSA-vh95-rmgr-6w4m present in versions of
minimistbefore 1.2.2.What changes did you make?
optimistis deprecated and suggests usingminimistdirectly or usingyargs. It seemed relatively straightforward to useminimistdirectly here.minimistby upgrading a sub-dependency,mkdirp.Is there anything you'd like reviewers to focus on?
It doesn’t look like there are a ton (any?) tests associated with the command-line interface specifically. I ran it a few times and it seems to work as expected, but that’s something to keep an eye out for when reviewing.
Fixes #614