-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Renovate CLI switch parsing #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BigBlueHat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! We do need to get off optimist, and minimist seems sufficient with the least amount of code restructuring.
I left a few inline comments which would hopefully help make the usage code a bit clearer.
Appreciate the contribution!
🎩
also remove bad console log
tabs were a bad choice, I don't know what I was thinking
|
I'm currently working my way through the pile of PRs, and I have to say I like #131 better than this approach. @BigBlueHat @indexzero what do you think about this |
|
I am officially laying this PR down in favor of nconf in #131, it's very well done over there. |
This commit makes a handful of closely-related changes, all aimed at refactoring
bin/http-serverfor better maintainability.optimistto the smallerminimistfor CLI parsing-and--option, thereby removing the need for patterns likeargv.g || argv.gzipFalseis a string, so it should not work on a boolean switch. Instead, this new help dialog encourages using the--noprefix. For example,-ienables autoIndex, and--no-idisables it. This is already possible, so it's not actually an interface change