Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore hidden input without label #890

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Jan 27, 2022

Short description of what this resolves:
fix #866

Proposed changes:

@github-actions github-actions bot added core Relates to HTMLHint's core APIs and features test labels Jan 27, 2022
@is2ei is2ei force-pushed the ignore-hidden-input-without-label branch from 39e4105 to 22a5962 Compare January 27, 2022 16:31
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #890 (399518f) into master (fdd4c21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   96.44%   96.45%           
=======================================
  Files           1        1           
  Lines         901      902    +1     
  Branches      191      192    +1     
=======================================
+ Hits          869      870    +1     
  Misses         13       13           
  Partials       19       19           
Impacted Files Coverage Δ
dist/htmlhint.js 96.45% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd4c21...399518f. Read the comment docs.

Copy link
Contributor

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!
Maybe obvious, but might make sense to have a test just to make sure there is not issue flagged if a Hidden does have a label.

@is2ei is2ei force-pushed the ignore-hidden-input-without-label branch from 17d2fc6 to 399518f Compare January 27, 2022 16:47
@is2ei
Copy link
Contributor Author

is2ei commented Jan 27, 2022

@nschonni
Thanks for your comment. I added tests.

@nschonni nschonni merged commit 37b0696 into htmlhint:master Jan 27, 2022
@thedaviddias
Copy link
Member

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@is2ei is2ei deleted the ignore-hidden-input-without-label branch January 30, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Relates to HTMLHint's core APIs and features released test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input-requires-label should ignore type=hidden fields
3 participants