-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore hidden input without label #890
fix: ignore hidden input without label #890
Conversation
39e4105
to
22a5962
Compare
Codecov Report
@@ Coverage Diff @@
## master #890 +/- ##
=======================================
Coverage 96.44% 96.45%
=======================================
Files 1 1
Lines 901 902 +1
Branches 191 192 +1
=======================================
+ Hits 869 870 +1
Misses 13 13
Partials 19 19
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Thanks!
Maybe obvious, but might make sense to have a test just to make sure there is not issue flagged if a Hidden does have a label.
17d2fc6
to
399518f
Compare
@nschonni |
🎉 This PR is included in version 1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Short description of what this resolves:
fix #866
Proposed changes: