Change RegExp to allow special characters as attribute name #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1:+1::shipit: |
felixfbecker
force-pushed
the
fix-attr-names-regexp
branch
from
c5147d6
to
f5ecc52
Compare
Fixes htmlhint#100 See W3C HTML specification: http://www.w3.org/TR/html-markup/syntax.html#syntax-attributes
felixfbecker
force-pushed
the
fix-attr-names-regexp
branch
from
f5ecc52
to
00d80bb
Compare
|
Your code is bad, miss something, i fixed: b6a4d1a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
From the W3C HTML specification:
The current behavior however only allows alphanumeric characters, hyphens and double colons as attribute names, which for example breaks parsing of attributes in Angular 2 and Polymer, which make use of brackets, asterisks or the dollar sign.
This PR changes the regular expression to conform to the W3C HTML spec by allowing anything but
"'>/=, whitespace or the control characters U+0000—U+001F (C0 controls), U+007F (delete), and U+0080—U+009F (C1 controls).This is a much better solution than PR #114, which only whitelists characters used in Angular 2 (brackets and asterisk).