Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can the command return an error code? #79

Closed
waldyrious opened this issue Oct 9, 2015 · 2 comments
Closed

Can the command return an error code? #79

waldyrious opened this issue Oct 9, 2015 · 2 comments

Comments

@waldyrious
Copy link
Contributor

I tried to set this up with Travis but it doesn't detect that the command failed, because of:

The command "htmlhint --config htmlhint.conf index.xhtml" exited with 0.

I suppose this is the line that needs to be adjusted for this to work.
yaniswang added a commit that referenced this issue Oct 9, 2015
@yaniswang
close issue: #79, fix exit with 0 when hint errors
30860c9 
attr-unsafe-chars(rule): exclude `\r\n`
@yaniswang
Copy link
Contributor

Fixed, please try again.
https://www.npmjs.com/package/htmlhint

https://travis-ci.org/yaniswang/HTMLHint-test/jobs/84431876

@waldyrious
Copy link
Contributor Author

Confirmed, it works as expected. That was fast, thanks!

@waldyrious waldyrious mentioned this issue Oct 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waldyrious @yaniswang