Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why types are not shipped into npm together? #633

Open
JounQin opened this issue Apr 23, 2021 · 7 comments
Open

Why types are not shipped into npm together? #633

JounQin opened this issue Apr 23, 2021 · 7 comments
Labels
bug Functionality that does not work as intended/expected keep-unstale The issue will not be marked as stale by the stale-bot

Comments

@JounQin
Copy link

JounQin commented Apr 23, 2021

This project is written in TypeScript now, but we can't use its typings directly.

@thedaviddias thedaviddias added the bug Functionality that does not work as intended/expected label May 26, 2021
@thedaviddias
Copy link
Member

@JounQin thanks for pointing that out. I will review this soon.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Jul 25, 2021
@JounQin
Copy link
Author

JounQin commented Jul 27, 2021

cc @thedaviddias

@stale stale bot removed the bot:stale Issue marked as stale because there was no activity label Jul 27, 2021
@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Sep 25, 2021
@stale stale bot closed this as completed Oct 9, 2021
@thedaviddias thedaviddias added keep-unstale The issue will not be marked as stale by the stale-bot and removed bot:stale Issue marked as stale because there was no activity labels Oct 23, 2021
@martin-badin
Copy link

I created PR to solve this issue #865

@nschonni nschonni reopened this Jan 14, 2022
martin-badin pushed a commit to martin-badin/HTMLHint that referenced this issue Jan 14, 2022
martin-badin pushed a commit to martin-badin/HTMLHint that referenced this issue Jan 18, 2022
@htmlhint htmlhint deleted a comment from stale bot Sep 14, 2022
@htmlhint htmlhint deleted a comment from stale bot Sep 14, 2022
@admir86
Copy link

admir86 commented Jan 31, 2023

any updates on this?

@broofa
Copy link

broofa commented Oct 23, 2023

Landed here while trying to figure out why TS was complaining about "href-abs-or-rel": false as a config option (docs explicitly say false is a valid value!). Was over at the Definitely Typed project looking at the type defs there, then came here to see if they aligned with the source code here and was surprised to see everything written in TS here.

So... I guess that's two bugs. Types don't align with the docs, and types should really be published with the package.

@JounQin
Copy link
Author

JounQin commented Oct 24, 2023

I don't think this project is actively maintained by @thedaviddias sadly.

@hyperupcall
Copy link
Contributor

hyperupcall commented Oct 26, 2023

This is something I'd be interested in tackling, but (the old PR implementing this was closed), but it seems that good features are stalled in the PR queue. I currently have 2 small PRs that still need to be reviewed and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality that does not work as intended/expected keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Development

No branches or pull requests

7 participants