feat(cli): display warning log message when it can not parse config (#…

…893) fix #662
htmlhint · Sep 6, 2022 · bad68d9 · bad68d9
1 parent 09a0c86
commit bad68d9
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 2 deletions.
diff --git a/dist/cli/htmlhint.js b/dist/cli/htmlhint.js
diff --git a/src/cli/htmlhint.ts b/src/cli/htmlhint.ts
@@ -407,7 +407,8 @@ function getConfig(
         configPath: configPath,
       })
     } catch (e) {
-      // ignore
+      console.log('   Config could not be parsed: %s', chalk.yellow(configPath))
+      console.log('')
     }
 
     return ruleset

diff --git a/test/conf/invalid-json.conf b/test/conf/invalid-json.conf
@@ -0,0 +1,3 @@
+{
+    "attr-lowercase": false,
+}
diff --git a/test/conf/valid-json.conf b/test/conf/valid-json.conf
@@ -0,0 +1,3 @@
+{
+    "attr-lowercase": false
+}
diff --git a/test/executable.spec.js b/test/executable.spec.js
@@ -35,3 +35,37 @@ describe('Executable', () => {
     })
   })
 })
+
+describe('Config', () => {
+  it('should not display warning log message when it can parse config file', (done) => {
+    ChildProcess.exec(
+      [
+        'node',
+        path.resolve(__dirname, '../bin/htmlhint'),
+        path.resolve(__dirname, './html/executable.html'),
+        '--config',
+        path.resolve(__dirname, './conf/valid-json.conf'),
+      ].join(' '),
+      (error, stdout) => {
+        expect(stdout).toContain('Config loaded:')
+        done()
+      }
+    )
+  })
+
+  it('should display warning log message when it can not parse config file', (done) => {
+    ChildProcess.exec(
+      [
+        'node',
+        path.resolve(__dirname, '../bin/htmlhint'),
+        path.resolve(__dirname, './html/executable.html'),
+        '--config',
+        path.resolve(__dirname, './conf/invalid-json.conf'),
+      ].join(' '),
+      (error, stdout) => {
+        expect(stdout).toContain('Config could not be parsed:')
+        done()
+      }
+    )
+  })
+})