Disable rule at false value

htmlhint · Dec 17, 2013 · 562645a · 562645a
1 parent e200a41
commit 562645a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/core.js b/src/core.js
@@ -36,9 +36,11 @@ var HTMLHint = (function (undefined) {
         var rules = HTMLHint.rules,
             rule;
         for (var id in ruleset){
-            rule = rules[id];
-            if (rule !== undefined){
-                rule.init(parser, reporter, ruleset[id]);
+            if (ruleset[id]) {
+                rule = rules[id];
+                if (rule !== undefined){
+                    rule.init(parser, reporter, ruleset[id]);
+                }
             }
         }
 

diff --git a/test/rules/attr-lowercase.spec.js b/test/rules/attr-lowercase.spec.js
@@ -29,4 +29,10 @@ describe('Rules: '+ruldId, function(){
         expect(messages.length).to.be(0);
     });
 
+    it('Set is false not result in an error', function(){
+        var code = '<p TEST="abc">';
+        ruleOptions[ruldId] = false;
+        var messages = HTMLHint.verify(code, ruleOptions);
+        expect(messages.length).to.be(0);
+    });
 });