fix attr-value-double-quotes: without quotes should not result in an …

…error
htmlhint · Sep 1, 2013 · 533e176 · 533e176
1 parent 98a54ea
commit 533e176
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 11 deletions.
diff --git a/CHANGE.md b/CHANGE.md
@@ -1,6 +1,12 @@
 HTMLHint change log
 ====================
 
+## ver 0.9.4 (2013-9-1)
+
+fix:
+
+1. fix attr-value-double-quotes: without quotes should not result in an error
+
 ## ver 0.9.3 (2013-5-24)
 
 add:

diff --git a/bin/htmlhint b/bin/htmlhint
@@ -26,7 +26,7 @@ program.on('--help', function(){
 });
 
 program
-    .version('0.9.3')
+    .version('0.9.4')
     .usage('[options] <file ...>')
     .option('-l, --list', 'show all of the rules available.')
     .option('-c, --config <file>', 'custom configuration file.')

diff --git a/coverage.html b/coverage.html
diff --git a/lib/htmlhint.js b/lib/htmlhint.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "htmlhint",
-  "version": "0.9.3",
+  "version": "0.9.4",
   "description": "A Static Code Analysis Tool for HTML",
   "main": "./index",
   "dependencies": {

diff --git a/src/rules/attr-value-double-quotes.js b/src/rules/attr-value-double-quotes.js
@@ -13,7 +13,7 @@ HTMLHint.addRule({
                 col = event.col + event.tagName.length + 1;
             for(var i=0, l=attrs.length;i<l;i++){
                 attr = attrs[i];
-                if(attr.quote !== '"' && (attr.value !== '' || (attr.value === attr.quote === ''))){
+                if(attr.quote !== '"' && attr.quote !== ''){
                     reporter.error('The value of attribute [ '+attr.name+' ] must closed by double quotes.', event.line, col + attr.index, self, attr.raw);
                 }
             }

diff --git a/test/rules/attr-value-double-quotes.spec.js b/test/rules/attr-value-double-quotes.spec.js
@@ -10,15 +10,12 @@ var HTMLHint  = require("../../index").HTMLHint;
 describe('Rules: attr-value-double-quotes', function(){
 
     it('Attribute value closed by single quotes should result in an error', function(){
-        var code = '<a href=\'abc\' title=abc>';
+        var code = '<a href=\'abc\'>';
         var messages = HTMLHint.verify(code, {'attr-value-double-quotes': true});
-        expect(messages.length).to.be(2);
+        expect(messages.length).to.be(1);
         expect(messages[0].rule.id).to.be('attr-value-double-quotes');
         expect(messages[0].line).to.be(1);
         expect(messages[0].col).to.be(3);
-        expect(messages[1].rule.id).to.be('attr-value-double-quotes');
-        expect(messages[1].line).to.be(1);
-        expect(messages[1].col).to.be(14);
     });
 
     it('Attribute value no closed should not result in an error', function(){
@@ -33,4 +30,10 @@ describe('Rules: attr-value-double-quotes', function(){
         expect(messages.length).to.be(0);
     });
 
+    it('Attribute value without quotes should not result in an error', function(){
+        var code = '<input type=text>';
+        var messages = HTMLHint.verify(code, {'attr-value-double-quotes': false});
+        expect(messages.length).to.be(0);
+    });
+
 });