Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Открывается и закрывается #7

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

OlegSulitskii
Copy link
Contributor

@OlegSulitskii OlegSulitskii commented Feb 16, 2025

@keksobot keksobot changed the title ДЗ - 8.14. Открывается и закрывается Открывается и закрывается Feb 16, 2025
keksobot pushed a commit that referenced this pull request Feb 16, 2025
@keksobot
Copy link
Contributor

♻️ Я собрал ваш пулреквест. Посмотреть можно здесь.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот файл уже удалить можно

};

const closeBigPicture = () => {
const bigPictureCloseActions = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Эту функцию можно за пределы closeBigPicture вынести

}
});

closeBigPicture();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registerEventsCloseBigPicture. И логичнее это тоже в if положить

@AlSudar AlSudar merged commit 00891d1 into htmlacademy-javascript:master Feb 17, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants