fix form not properly submitting ?url= #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: - html-preview#4 as much as I agree with other comments that the `?url=` segment is a bit awks, IMO it is best practice to use explicit parameters; it is not as if GH Pages lets you do this anyway This kind of long-term shortcut would be best handled on the host level, e.g. with a Cloudflare redirect `htmlfil.es/(.+) -> https://html-preview.github.io/?url=$1`
|
I am sorry for being so late! Thankl you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
as much as I agree with other comments that the
?url=segment is a bit awks, IMO it is best practice to use explicit parameters; it is not as if GH Pages lets you do this anyway This kind of long-term shortcut would be best handled on the host level, e.g. with a Cloudflare redirecthtmlfil.es/(.+) -> https://html-preview.github.io/?url=$1