Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs.yml #59

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

lukashergt
Copy link
Collaborator

The docs on readthedocs are currently failing. I suspect this has to do with the missing build block specifying what OS to use. Let's see whether this fixes it.

@htjb, could you tell readthedocs to build this branch, please? (alternatively give me the power and I'll fiddle around)

@htjb
Copy link
Owner

htjb commented Mar 11, 2024

@htjb, could you tell readthedocs to build this branch, please? (alternatively give me the power and I'll fiddle around)

How do I build the docs for the branch? Never done this before...

@htjb
Copy link
Owner

htjb commented Mar 11, 2024

@lukashergt I gave readthedocs permission to build PRs and refreshed the webhook but not seeing the build here. I can add you as a maintainer on the docs? What's your readthedocs username?

@lukashergt
Copy link
Collaborator Author

@lukashergt I gave readthedocs permission to build PRs and refreshed the webhook but not seeing the build here.

The builds can be viewed here:
https://readthedocs.org/projects/margarine/builds/

I can add you as a maintainer on the docs? What's your readthedocs username?

Same as my GitHub username: lukashergt

@lukashergt
Copy link
Collaborator Author

Nice, looks like this PR does indeed fix the previously failing docs:
https://readthedocs.org/projects/margarine/builds/

image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.41%. Comparing base (12405af) to head (e910d3d).
Report is 9 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   82.41%   82.41%           
=======================================
  Files           5        5           
  Lines         580      580           
=======================================
  Hits          478      478           
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukashergt
Copy link
Collaborator Author

The failed python 3.9 test should be unrelated to this PR. That test also fails on the master branch.

@htjb
Copy link
Owner

htjb commented Mar 11, 2024

Ahh maybe it needed a commit to trigger the build. Thanks for the help with the docs Lukas this is great. Go ahead and merge.

The failed python 3.9 test should be unrelated to this PR.

Hmm there is a known issue with the tests that needs fixing (just haven't got to it yet). This is new though... looks like tensorflow was updated in the last few weeks and its broken something...

You're right though that this is not related to this PR so go ahead and merge. Thanks again!

@htjb htjb mentioned this pull request Mar 11, 2024
@lukashergt lukashergt merged commit 3b0ce70 into htjb:master Mar 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants