-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Version Increment Check Workflow #53
Conversation
This is done so version number is only set in one place, README.rst, reducing the chance of self-inconsistencies
Based on that of globalemu and anesthetic. This will intentionally fail on PR so I can check it is working.
Certainly seems to work, though I've personally never been a fan of writing otherwise lgtm |
Looks good @ThomasGesseyJones! Just one query about the @AdamOrmondroyd what is lgmt hahaa? |
Looks good to me (one I've picked up from pandas PRs), though it seems to cause no end of confusion with you lot |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 5 5
Lines 578 578
=======================================
Hits 476 476
Misses 102 102 ☔ View full report in Codecov by Sentry. |
I have removed I mistakenly copied it over alongside |
Awesome lgtm thanks @ThomasGesseyJones! Please go ahead and squash and merge |
Adds a GitHub workflow that automatically checks the version number has been incremented in a PR. It fails if the version has not been incremented appropriately. This PR also removes the duplicate specifications of version numbers by having
setup.py
read the version number fromREADME.rst
to avoid self-inconsistency issues.This feature was requested in #52 .
Note: This PR should intentionally fail the version increment check initially as part of testing.