Updating sample minimum/max handling for cluster maf #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 79.44% 79.52% +0.07%
==========================================
Files 5 5
Lines 506 503 -3
==========================================
- Hits 402 400 -2
+ Misses 104 103 -1
☔ View full report in Codecov by Sentry. |
|
PR evolved from some work looking at the clusterMAF KL calculation (which looks fine!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clusterMAF components were previously normalised based on the bounds of the cluster. This is fine but causes issues when calculating log probabilities for samples outside the bounds of the cluster. I'd fixed this with a catch that set the log-probability of these samples to 1e-300. However, a perhaps better way to deal with this is to normalise the clusters with the range of the target distributions, as in this PR.