Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow hProperties in UnistNodeType and data on UnistTreeType #49

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix: allow hProperties in UnistNodeType and data on UnistTreeType #49

merged 1 commit into from
Apr 12, 2024

Conversation

enryIT
Copy link
Contributor

@enryIT enryIT commented Apr 10, 2024

Removing Node fixes:

  • Argument of type 'UnistTreeType' is not assignable to parameter of type 'Node'.

Adding the ExtendedData interface fixes:

  • Property 'hProperties' does not exist on type 'Data'.

Removing Node<Data> fixes:
- Argument of type 'UnistTreeType' is not assignable to parameter of type 'Node'.

Adding the ExtendedData interface fixes:
- Property 'hProperties' does not exist on type 'Data'.
Copy link

vercel bot commented Apr 10, 2024

@enryIT is attempting to deploy a commit to the Leo Huynh's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leo-huynh-dot-dev-tyyf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 3:18am

Copy link
Owner

@hta218 hta218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good @enryIT. Thank you for your contribution!

@hta218 hta218 merged commit 324cb95 into hta218:main Apr 12, 2024
4 checks passed
@hta218 hta218 added the bug Something isn't working label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants