Skip to content

Bugfix: lowering of variadic templates of functions #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsutter merged 2 commits into from
Jan 1, 2024
Merged

Bugfix: lowering of variadic templates of functions #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6496423
Missing trailing '...' in variadic template arguments.
MaxSagebaum Dec 21, 2023
e5d4dc2
Added regression test.
MaxSagebaum Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions regression-tests/pure2-variadics.cpp2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Type pack expansion
x: <Ts...: type> type = {
tup: std::tuple<Ts...> = ();

func: () = {}
}

left_fold_print: <Args...: type> (inout out: std::ostream, args...: Args) = {
Expand Down
15 changes: 10 additions & 5 deletions regression-tests/test-results/pure2-variadics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,21 @@ template<typename ...Ts> class x;
#line 3 "pure2-variadics.cpp2"
template<typename ...Ts> class x {
private: std::tuple<Ts...> tup {};

public: static auto func() -> void;
public: x() = default;
public: x(x const&) = delete; /* No 'that' constructor, suppress copy */
public: auto operator=(x const&) -> void = delete;

#line 5 "pure2-variadics.cpp2"
#line 7 "pure2-variadics.cpp2"
};

template<typename ...Args> auto left_fold_print(std::ostream& out, Args const& ...args) -> void;

#line 12 "pure2-variadics.cpp2"
#line 14 "pure2-variadics.cpp2"
template<typename ...Args> [[nodiscard]] auto all(Args const& ...args) -> bool;

#line 16 "pure2-variadics.cpp2"
#line 18 "pure2-variadics.cpp2"
template <typename ...Args> [[nodiscard]] auto make_string(Args&& ...args) -> auto;

template <typename T, typename ...Args> [[nodiscard]] auto make(Args&& ...args) -> auto;
Expand All @@ -43,7 +45,10 @@ auto main() -> int;

#line 1 "pure2-variadics.cpp2"

#line 7 "pure2-variadics.cpp2"
#line 6 "pure2-variadics.cpp2"
template <typename ...Ts> auto x<Ts...>::func() -> void{}

#line 9 "pure2-variadics.cpp2"
template<typename ...Args> auto left_fold_print(std::ostream& out, Args const& ...args) -> void{
// Binary left fold expression
(out << ... << args);
Expand All @@ -59,7 +64,7 @@ template <typename T, typename ...Args> [[nodiscard]] auto make(Args&& ...args)

auto main() -> int
{
x<int,long,std::string> auto_22_5 {};
x<int,long,std::string> auto_24_5 {};

std::cout << std::string("xyzzy", 3) << "\n";
std::cout << make_string("plugh", cpp2::u8{3}) << "\n";
Expand Down
3 changes: 3 additions & 0 deletions source/to_cpp1.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4888,6 +4888,9 @@ class cppfront
for (auto& tparam : parent->template_parameters->parameters) {
assert (tparam->has_name());
list += separator + tparam->name()->to_string();
if(tparam->declaration->is_variadic) {
list += "...";
}
separator = ",";
}
list += ">";
Expand Down