-
Notifications
You must be signed in to change notification settings - Fork 266
feat(reflect): add function_declaration API to set initializer and inspect parameters
#831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hsutter
merged 11 commits into
hsutter:main
from
JohelEGP:reflect_function_parameters_and_initializer
Dec 17, 2023
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cf88bd1
feat(reflect): add `function_declaration::get_parameters`
JohelEGP c499d3b
feat(reflect): add `function_declaration::add_initializer`
JohelEGP a51e2d1
fix(reflect): actually return the parent
JohelEGP cb148bc
feat(reflect): add `declaration::get_arguments`
JohelEGP 66e83d2
feat(reflect): add `get_member_functions_needing_initializer`
JohelEGP 8676473
Pre-merge review pass
hsutter d72a055
Restore preconditions for `add_initializer`
hsutter 6c2b434
Second review: Add graceful termination for a metafunction preconditi…
hsutter 3813b46
Report original source string on parse errors
hsutter 08481ff
Merge branch 'main' into reflect_function_parameters_and_initializer
hsutter cb865b4
regenerate `reflect.h`
JohelEGP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually don't expose the
unique_ptr. Also I usually asconst.Perhaps
-> std::vector<parameter_declaration_node const*>?